Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[esp32] Support level control cluster in ESP32 all cluster app #7513

Merged
merged 1 commit into from
Jun 10, 2021
Merged

[esp32] Support level control cluster in ESP32 all cluster app #7513

merged 1 commit into from
Jun 10, 2021

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Jun 10, 2021

Problem

  • Fix level control cluster handlers missing in esp32 all-cluster-app.

Change overview

  • Add LEDWidget::SetBrightness
  • Add level control handling logic and coexistence with On/Off cluster.

Testing

Manually paired with chip-dev-ctrl then tested with:

zcl OnOff On 12344321 1 1
zcl LevelControl MoveToLevel 12344321 1 1 level=10 transitionTime=0 optionMask=0 optionOverride=0
zcl OnOff Off 12344321 1 1
zcl OnOff Toggle 12344321 1 1
zcl LevelControl MoveToLevel 12344321 1 1 level=255 transitionTime=0 optionMask=0 optionOverride=0

@gjc13 gjc13 requested a review from dhrishi June 10, 2021 10:51
@gjc13 gjc13 force-pushed the esp-all-cluster-level-control branch from af8f4fc to 3f4904c Compare June 10, 2021 11:29
@github-actions
Copy link

Size increase report for "esp32-example-build" from e0c7b6d

File Section File VM
chip-all-clusters-app.elf .flash.text 388 388
chip-all-clusters-app.elf .flash.rodata 48 48
chip-all-clusters-app.elf .dram0.bss 0 8
chip-all-clusters-app.elf .dram0.data -8 -8
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_loc,0,52472
.debug_info,0,4304
.debug_line,0,1572
.debug_str,0,424
.flash.text,388,388
.strtab,0,341
.debug_ranges,0,104
.debug_frame,0,96
.symtab,0,80
.debug_abbrev,0,76
.flash.rodata,48,48
.debug_aranges,0,32
.dram0.bss,8,0
.shstrtab,0,-1
.dram0.data,-8,-8
[Unmapped],0,-40

@andy31415 andy31415 merged commit 495b033 into project-chip:master Jun 10, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@gjc13
[esp32] Support level control cluster in ESP32 all cluster app (proje…
16566e4 
…ct-chip#7513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@dhrishi dhrishi Awaiting requested review from dhrishi

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gjc13 @andy31415 @msandstedt @woody-apple